-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use AT_MOST measurespec when onyl max dimension is defined #200
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I think this pr only support for the top-most node, it's not enough. |
ghost
pushed a commit
to facebook/react-native
that referenced
this pull request
Jul 8, 2016
Summary: facebook/yoga#200 Make use of max dimension styles to allow root to be measured with AT_MOST measure mode Reviewed By: IanChilds Differential Revision: D3513505 fbshipit-source-id: 169f49717e896eb6270b52fb7115ce005aa0e3a8
emilsjolander
added a commit
that referenced
this pull request
Jul 8, 2016
Add missing js implementation for PR #200
samerce
pushed a commit
to iodine/react-native
that referenced
this pull request
Aug 23, 2016
Summary: facebook/yoga#200 Make use of max dimension styles to allow root to be measured with AT_MOST measure mode Reviewed By: IanChilds Differential Revision: D3513505 fbshipit-source-id: 169f49717e896eb6270b52fb7115ce005aa0e3a8
mpretty-cyro
pushed a commit
to HomePass/react-native
that referenced
this pull request
Aug 25, 2016
Summary: facebook/yoga#200 Make use of max dimension styles to allow root to be measured with AT_MOST measure mode Reviewed By: IanChilds Differential Revision: D3513505 fbshipit-source-id: 169f49717e896eb6270b52fb7115ce005aa0e3a8
jordwalke
added a commit
to jordwalke/css-layout
that referenced
this pull request
Oct 7, 2016
https://github.com/facebook/css-layout/pull/203/files Summary: Test Plan: Reviewers: CC:
tungdo194
pushed a commit
to tungdo194/rn-test
that referenced
this pull request
Apr 28, 2024
Summary: facebook/yoga#200 Make use of max dimension styles to allow root to be measured with AT_MOST measure mode Reviewed By: IanChilds Differential Revision: D3513505 fbshipit-source-id: 169f49717e896eb6270b52fb7115ce005aa0e3a8
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make use of max dimension styles to allow root to be measured with AT_MOST measurespec